Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Poster 404 causes exception in Chrome 37 #1465

Closed
dmlap opened this issue Aug 30, 2014 · 1 comment
Closed

Poster 404 causes exception in Chrome 37 #1465

dmlap opened this issue Aug 30, 2014 · 1 comment
Labels
bug confirmed

Comments

@dmlap
Copy link
Member

dmlap commented Aug 30, 2014

If you set a poster URL that 404s in Chrome 37, an error event is triggered on the video element. The error property on the video element remains unset however, which causes the error handling code in video.js to dereference undefined and throw an error.

Live example
dmlap added a commit to videojs/videojs-contrib-ads that referenced this issue Sep 2, 2014
@dmlap
Add test case for snapshot restore with blocked ads
61c76a5 
Clean up some distracting error messages during the ad tests. Add a test that checks to make sure the src attribute is restored if currentSrc never gets changed. Worked around an issue with error events and bad poster images in video.js error handling (videojs/video.js#1465).
@mmcc mmcc added bug labels Sep 2, 2014
@Globulopolis Globulopolis mentioned this issue Sep 2, 2014
Closed
@mmcc
Copy link
Member

mmcc commented Sep 2, 2014

Just to make sure this gets tied back in, looks like according to #1471 this might not be limited to Chrome 37.

dmlap added a commit to dmlap/video.js that referenced this issue Sep 4, 2014
@dmlap
Make sure the error property is set before proxying through the tech.
b8d27ef 
Some error events don't cause the error property on the video element to be set. In that case, handle the event like any other. Fixes videojs#1465.
@dmlap dmlap mentioned this issue Sep 4, 2014
Closed
@dmlap dmlap closed this as completed in b9181ee Sep 5, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
bug confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure the error property is set before proxying through the tech. dmlap/video.js
2 participants
@dmlap @mmcc