Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hardcoded reference to SWF does not follow httpS #188

Closed
tomsaffell opened this issue May 18, 2012 · 2 comments
Closed

Hardcoded reference to SWF does not follow httpS #188

tomsaffell opened this issue May 18, 2012 · 2 comments

Comments

@tomsaffell
Copy link

When self-hosting video.js as an httpS resource (one one's own server) the script still tries to load the fallback swf from an http cdn:

line 79: flash: { swf: "http://vjs.zencdn.net/c/video-js.swf" },

This causes IE8 to issue a warning to the user "Do you want to view only the webpage content that was delivered securely?" - requires the user to click 'No' to proceed.

Suggested fix - detect when page is https, and in that case use a relative url e.g. /st/video-js.swf

@heff
Copy link
Member

heff commented May 18, 2012

Yeah, in the latest demo file i have it instructing to update the flash location if hosted locally.

<script> _V_.options.flash.swf = "video-js.swf"; </script>

Though, we have an SSL on the CDN now, so could probably also just use '//vjs.zencdn.net/c/video-js.swf' instead.

On May 18, 2012, at 3:55 PM, tomsaffell wrote:

When self-hosting video.js as an httpS resource (one one's own server) the script still tries to load the fallback swf from an http cdn:

line 79: flash: { swf: "http://vjs.zencdn.net/c/video-js.swf" },

This causes IE8 to issue a warning to the user "Do you want to view only the webpage content that was delivered securely?" - requires the user to click 'No' to proceed.

Suggested fix - detect when page is https, and in that case use a relative url e.g. /st/video-js.swf


Reply to this email directly or view it on GitHub:
#188

@heff
Copy link
Member

heff commented May 24, 2013

This should be fixed in the latest version.

@heff heff closed this as completed May 24, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants