Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ARIA region role and ARIA label to player element #3201

Closed
chrisauclair opened this issue Mar 23, 2016 · 5 comments
Closed

Add ARIA region role and ARIA label to player element #3201

chrisauclair opened this issue Mar 23, 2016 · 5 comments
Labels
a11y This item might affect the accessibility of the player

Comments

@chrisauclair
Copy link
Contributor

If a document contains multiple players, screen readers can inadvertently combine some of the controls. A specific example occurs when using JAWS in IE 9+.

The solution is to add a "role" attribute with the value "region" to the player element, and also add an ARIA label identifying the player as an "audio player" or "video player", depending on the type. This has the benefit of adding the player to the screen reader navigation, and also fixing any bugs with the controls.

@chrisauclair
Copy link
Contributor Author

Identifying a region as a video or audio player eliminates the need to label controls as "video control name" ("video progress bar" comes to mind). That's redundant, because the SR user will know they're in a "video" region. It will also eliminate the current issue where some audio controls identify as video controls because "video" is hardcoded into their label.

@gkatsev
Copy link
Member

gkatsev commented Mar 28, 2016

Makes sense to me. @OwenEdwards thoughts?
Care to submit a PR?

@gkatsev gkatsev added the a11y This item might affect the accessibility of the player label Mar 28, 2016
@OwenEdwards
Copy link
Member

What I was thinking of in #2770 was essentially this coupled with the specific Title functionality from the videojs Dock plug-in. So yes, I think it makes sense.

@chrisauclair
Copy link
Contributor Author

@gkatsev , I can submit a PR that fixes this when I get a chance, since I've already fixed it locally.

chrisauclair added a commit to chrisauclair/video.js that referenced this issue Mar 29, 2016
Fixes bug in JAWS with IE where controls for multiple players are
unavailable to screen reader navigation
chrisauclair added a commit to chrisauclair/video.js that referenced this issue Mar 29, 2016
This is not necessary when using the ARIA region role. Also confusing
language when used with the audio player.
@gkatsev
Copy link
Member

gkatsev commented Apr 5, 2016

Closed by #3227.

@gkatsev gkatsev closed this as completed Apr 5, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
a11y This item might affect the accessibility of the player
Projects
None yet
Development

No branches or pull requests

3 participants