Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing controls on iOS when switching back to html5 tech #561

Closed
tomsaffell opened this issue Jun 5, 2013 · 0 comments
Closed

Missing controls on iOS when switching back to html5 tech #561

tomsaffell opened this issue Jun 5, 2013 · 0 comments

Comments

@tomsaffell
Copy link

To recreate

  1. setup vjs with 'controls' attr in video tag
  2. via js, play an asset with a non-html tech (e.g. youtube)
  3. via js, play an asset with html tech

Observed

At 3, there are no controls

Expected

At 3, there should be iOS native controls for the video

Fix

html5.js has

// Update specific tag settings, in case they were overridden
 var attrs = ['autoplay','preload','loop','muted'];

The 'controls' is not present, presumably because often times we dont want a controls attr in the video tag. I suggest a fix of:

if (player.options_.controls && player.options_['customControlsOnMobile'] !== true && (vjs.IS_IOS || vjs.IS_ANDROID)) {
attrs.push('controls');
}
heff added a commit to heff/video.js that referenced this issue Jul 31, 2013
@heff heff closed this as completed in 02de927 Aug 9, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant