Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No flash fallback if type contains codec information #781

Closed
doublex opened this issue Oct 16, 2013 · 3 comments
Closed

No flash fallback if type contains codec information #781

doublex opened this issue Oct 16, 2013 · 3 comments

Comments

@doublex
Copy link

doublex commented Oct 16, 2013

If the video-source contains codec-information, the flash-fallback won't work, e.g.:
‹source type='video/mp4; codecs="avc1.64001E, mp4a.40.2"' src="..."›

Suggested fix:

vjs.Flash.canPlaySource = function(srcObj){
  var type = srcObj.type.replace(/;.*/,'');
  if (type in vjs.Flash.formats || type in vjs.Flash.streamingFormats) { return 'maybe'; }
};
@heff
Copy link
Member

heff commented Oct 16, 2013

Yep, looks good to me. Want to make a pull request for it?

@doublex
Copy link
Author

doublex commented Oct 16, 2013

Sorry - I don't use git.
Could I create a "patch" file instead?

@heff
Copy link
Member

heff commented Oct 29, 2013

Fixed through #805

@heff heff closed this as completed Oct 29, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants