Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The bar is not centered in video control section #7989

Closed
KangXinzhi opened this issue Nov 3, 2022 · 2 comments
Closed

The bar is not centered in video control section #7989

KangXinzhi opened this issue Nov 3, 2022 · 2 comments
Labels
bug

Comments

@KangXinzhi
Copy link
Contributor

Description

image

image

Reduced test case

No response

Steps to reproduce

Errors

No response

What version of Video.js are you using?

^7.20.3

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

chrome 104.0.5112.81

What OS(es) and version(s) does this occur with?

mac
@KangXinzhi KangXinzhi added bug needs: triage This issue needs to be reviewed labels Nov 3, 2022
@KangXinzhi
Copy link
Contributor Author

i try fixed
image

hover：
image

@KangXinzhi KangXinzhi mentioned this issue Nov 3, 2022
Merged
7 tasks
@mister-ben mister-ben removed the needs: triage This issue needs to be reviewed label Nov 6, 2022
misteroneill pushed a commit that referenced this issue Nov 8, 2022
@KangXinzhi
fix(control-bar): make vertical alignment of slider handles more cons…
2b55958 
…istent (#7990)

Fixes #7989

BREAKING CHANGE: This changes how slider handles are styled, so custom skins that are targeting them may need to change.
@mister-ben
Copy link
Contributor

Fixed in #7990, which will be in the next v8.x release.

CSS like below could be used for v7.x players.

    .video-js .vjs-volume-level:before,
    .video-js .vjs-play-progress:before {
      top: unset !important;
      line-height: .35em;
    }

misteroneill pushed a commit that referenced this issue Nov 23, 2022
@KangXinzhi @misteroneill
fix(control-bar): make vertical alignment of slider handles more cons…
df40ae8 
…istent (#7990)

Fixes #7989

BREAKING CHANGE: This changes how slider handles are styled, so custom skins that are targeting them may need to change.
misteroneill pushed a commit that referenced this issue Nov 23, 2022
@KangXinzhi @misteroneill
fix(control-bar): make vertical alignment of slider handles more cons…
b7080f7 
…istent (#7990)

Fixes #7989

BREAKING CHANGE: This changes how slider handles are styled, so custom skins that are targeting them may need to change.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2023
edirub pushed a commit to edirub/video.js that referenced this issue Jun 8, 2023
@KangXinzhi @edirub
fix(control-bar): make vertical alignment of slider handles more cons…
c4dffd1 
…istent (videojs#7990)

Fixes videojs#7989

BREAKING CHANGE: This changes how slider handles are styled, so custom skins that are targeting them may need to change.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mister-ben @KangXinzhi