-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bower updates #1123
Bower updates #1123
Conversation
I believe the |
@gkatsev Roger that, reverted the commit and changed the version number in |
Cool, thanks!. @heff we need to update the release process to also change |
@gkatsev Yeah, that'd be great. Is video.js using semantic versioning by the way? |
@jonkoops yes. At least, it tries. |
@gkatsev, yeah we do. Feel like making a pull request for that? For videojs.com I used grunt-version, and that worked well. It could replace grunt-bump. |
@heff Seems like |
Got it, yeah that'd work. I was thinking it was deprecated, but that's grunt-tagrelease. On Mar 31, 2014, at 2:05 PM, Jon Koops notifications@github.com wrote:
|
@jonkoops If you can give that a go, that would be awesome. |
Sorry, I've been delayed on pulling this in because I need to do a little git magic to get this pulled into the stable branch instead of master. If you do make any updates, could you base them on stable and make a new PR against stable? |
I was thinking that we get the release process updated and we could just do a patch release. Or something. |
Yeah, exactly. A patch needs to be based on stable, otherwise it'd pull in any new features from master. |
@heff Looks like grunt-tagrelease is being deprecated in favour of grunt-release. I'll try to include it in my pull request. |
The NPM dependencies are generally very out-of-date:
|
Yeah, if you see any that are no longer used feel free to remove them. I wouldn't get into upgrading all of them. That could make this much more complicated to deal with. I'll try upgrading some of them when I do the next release. |
Oh, I see. |
Yeah, updating deps and devDeps should be a separate task. |
I'll go a ahead and close this pull request, I'll try to submit a patch for the release script soon. |
Updated version number in bower.json and removed deprecated component.json