Fullscreen #1504
Fullscreen #1504
Conversation
|
Up to this point we haven't really needed those events to fire when enterFullScreen is used and the native controls take over, because no buttons or other components are visible at least. What's the new case where we need those events in enterfullscreen mode? |
| @@ -79,7 +79,8 @@ goog.exportProperty(vjs.Player.prototype, 'supportsFullScreen', vjs.Player.proto | |||
| goog.exportProperty(vjs.Player.prototype, 'currentType', vjs.Player.prototype.currentType); | |||
| goog.exportProperty(vjs.Player.prototype, 'requestFullScreen', vjs.Player.prototype.currentType); | |||
| goog.exportProperty(vjs.Player.prototype, 'cancelFullScreen', vjs.Player.prototype.currentType); | |||
| goog.exportProperty(vjs.Player.prototype, 'isFullScreen', vjs.Player.prototype.currentType); | |||
|
@heff I'm not sure there really is any need for the videojs' fullscreenchange to fire. I can remove these if you think it's not worth having yet. |
|
If there's no specific use case behind it yet I think we can leave it out and save ourselves some longterm testing and maintenance overhead. If we get a real use case we can always come back to this. The export mistakes still need to be fixed though. :) |
|
export mistakes have been fixed. |
This event isn't really being used for this usecase right now, so, no need to trigger it.
|
@heff alright, the exports should be fixed now and we're no longer triggering the |
|
Being handled by #1511 now. |
isFullScreengets exported correctly.enterFullscreenin the html5 tech, add some functionality to toggleisFullscreenand trigger the vjsfullscreenchangeevent when on ios.