New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix for opening errorDisplay more than once #2966

Closed

forbesjo wants to merge 1 commit into videojs:master from forbesjo:fix-temp-error-display

Contributor

forbesjo commented Jan 4, 2016

Error display can be closed with error(null) therefore it should not be disposed on close.

This fix is related to #2850


          error display can be closed with error(null) therefore it should not …

6a71b23

…be disposed on close

Member

gkatsev commented Jan 4, 2016

Makes sense. LGTM.

gkatsev added patch confirmed labels

gkatsev closed this in

b84be55

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

confirmed patch