updated text track unit tests to use full es6 syntax #3148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran vjsstandard and fixed most linting issues
22 tasks
| @@ -2,33 +2,33 @@ import TextTrackList from '../../../src/js/tracks/text-track-list.js'; | |||
| import TextTrack from '../../../src/js/tracks/text-track.js'; | |||
| import EventTarget from '../../../src/js/event-target.js'; | |||
|
|
|||
| var noop = Function.prototype; | |||
| var genericTracks = [ | |||
| const noop = () => {}; | |||
There was a problem hiding this comment.
Looks like you actually made this unused now.
|
LGTM |
| let fixture = document.getElementById('qunit-fixture'); | ||
| let html = ''; |
There was a problem hiding this comment.
can we change this to a template string?
gkatsev
added
patch
|
LGTM. |
gkatsev
added
confirmed
and removed
needs: LGTM
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently a few of the unit tests are using partial es6 or no es6 at all. This Pull Request seeks to rectify that.
Specific Changes proposed
vjsstandard(where it would not break jshint)Requirements Checklist