Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

XHR and updatedisplay fixes for IE8 #3189

Closed
wants to merge 8 commits into from
Closed

XHR and updatedisplay fixes for IE8 #3189

wants to merge 8 commits into from

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Mar 17, 2016

No description provided.

@@ -333,6 +333,10 @@ class Tech extends Component {
script.onerror = () => {
this.trigger('vttjserror');
};
this.on('dispose', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope.

@dmlap
Copy link
Member

dmlap commented Mar 17, 2016

Could use a little more exposition around the use of proxyrequire but otherwise LGTM

@dmlap
Copy link
Member

dmlap commented Mar 17, 2016

LGTM

@gkatsev gkatsev closed this in dbdc411 Mar 17, 2016
@gkatsev gkatsev deleted the fix-ie8-tests branch March 17, 2016 22:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants