New API docs generated from the source code #747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Gruntfile.js package.json
… feature/doc-generator Conflicts: src/js/player.js
heff
added a commit
to heff/video.js
that referenced
this pull request
Oct 29, 2013
Closed
|
Closing in favor of #801 |
heff
added a commit
that referenced
this pull request
Oct 29, 2013
| grunt.loadNpmTasks('videojs-doc-generator'); | ||
|
|
||
| // grunt.loadTasks('./docs/tasks/'); | ||
| // grunt.loadTasks('../videojs-doc-generator/tasks/'); | ||
|
|
There was a problem hiding this comment.
Should these commented lines be removed?
There was a problem hiding this comment.
Yeah, they could be.
On Nov 4, 2013, at 12:18 PM, BCjwhisenant notifications@github.com wrote:
In Gruntfile.js:
@@ -130,6 +159,11 @@ module.exports = function(grunt) {
grunt.loadNpmTasks('grunt-contrib-less');
grunt.loadNpmTasks('grunt-s3');
grunt.loadNpmTasks('contribflow');
- grunt.loadNpmTasks('grunt-karma');
- grunt.loadNpmTasks('videojs-doc-generator');
- // grunt.loadTasks('./docs/tasks/');
- // grunt.loadTasks('../videojs-doc-generator/tasks/');
Should these commented lines be removed?
—
Reply to this email directly or view it on GitHub.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would love any feedback on the docs and doc structure.
vjs.Player.mdwould be the best one to check out.I still need to create the videojs-doc-generator repo and update the dependency, but I can run it locally to generate the docs.