Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(control-bar): audio player no longer responds to touch events #7825

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

amtins
Copy link
Contributor

@amtins amtins commented Jul 1, 2022

Description

  1. On mobile initialize an audio player
  2. Start the playback
  3. Wait for the vjs-user-inactive
  4. Attempt to use the slider to seek through the media
  5. Notice that it is no longer possible to use the slider unless you tap the control bar before.

This issue was introduced by #7329 in video.js v7.15.0

Specific Changes proposed

The idea is to reset the pointer-events to auto for the audio player so that the slider can be used on touch devices.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #7825 (fc0a5c5) into main (b22a08a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7825   +/-   ##
=======================================
  Coverage   80.93%   80.93%           
=======================================
  Files         116      116           
  Lines        7463     7463           
  Branches     1813     1813           
=======================================
  Hits         6040     6040           
  Misses       1423     1423           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22a08a...fc0a5c5. Read the comment docs.

@gkatsev gkatsev changed the title fix(_control-bar): audio player no longer responds to touch events fix(control-bar): audio player no longer responds to touch events Jul 1, 2022
@gkatsev gkatsev merged commit 1445f87 into videojs:main Jul 1, 2022
@amtins amtins deleted the fix/audio-player-touch-interaction branch July 4, 2022 07:54
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants