Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix skip-forward button accessibility issue #8532

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

tsi
Copy link
Contributor

@tsi tsi commented Dec 17, 2023

Description

Got a complaint from a customer about the Wave tool being mad at some empty button.
Somehow the skip-backward button does have a default controlText. only the forward one was missing it.

Specific Changes proposed

Add a default controlText for the button component

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors
Before After
image image

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2dc5b9) 82.65% compared to head (61e7781) 82.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8532   +/-   ##
=======================================
  Coverage   82.65%   82.65%           
=======================================
  Files         113      113           
  Lines        7605     7606    +1     
  Branches     1828     1828           
=======================================
+ Hits         6286     6287    +1     
  Misses       1319     1319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben merged commit af0fca3 into videojs:main Dec 21, 2023
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants