Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Fixes form markup in text track settings #8557

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

mister-ben
Copy link
Contributor

Description

Removes two messages in Chrome's issues tab relating to the text track settings

  • A form field element should have an id or name attribute
  • No label associated with a form field

Specific Changes proposed

Adds an id to each <select>, and sets the id as the for on associated <label>s.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@mister-ben mister-ben merged commit 46c9907 into videojs:main Jan 16, 2024
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants