Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: decode string when containing hexcode #8847

Closed
wants to merge 1 commit into from

Conversation

CarlosVillasenor
Copy link
Contributor

Description

Bugfix for when menu-item.js generates a vjs-menu-item-text with hexcode characters.

Specific Changes proposed

Decode string when containing hexcode in menu-item.js

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (fa7e648) to head (d29c1f7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/js/utils/str.js 60.00% 2 Missing ⚠️
src/js/menu/menu-item.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8847      +/-   ##
==========================================
+ Coverage   83.21%   83.75%   +0.54%     
==========================================
  Files         120      120              
  Lines        8065     8078      +13     
  Branches     1936     1941       +5     
==========================================
+ Hits         6711     6766      +55     
+ Misses       1354     1312      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant