Enable building videojs with browserify. #998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses browserify-shim to get browserify to recognize videojs. It uses dist/video-js/video.js for the main file of the module. To build using browserify, you just run browserify on the module and use --standalone (or -s) to make it produce a UMD file. This seems to work just fine in the browser (and requirejs looks like it'll work, though, I haven't tested it) but it won't work in node right now because videojs is doing a lot of stuff with 'document' directly and its causing problems in node.
|
Can be used in conjunction with |
Closed
| }, | ||
| "main": "./dist/video-js/video.dev.js", | ||
| "browser": { | ||
| "videojs": "./dist/video-js/video.js" |
There was a problem hiding this comment.
This won't actually work right now though since we don't push anything in dist yet, right?
There was a problem hiding this comment.
Yes, this again would depend on the exact way were publishing to npm.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses browserify-shim to get browserify to recognize videojs.
It uses dist/video-js/video.js for the main file of the module.
To build using browserify, you just run browserify on the module and
use --standalone (or -s) to make it produce a UMD file.
This seems to work just fine in the browser (and requirejs looks like
it'll work, though, I haven't tested it) but it won't work in node right
now because videojs is doing a lot of stuff with 'document' directly and
its causing problems in node.