Feat: Add support for ceiling lamps with "moonlight" mode #49
Conversation
|
Hello @okonet, Thanks for this! Looks good to me, although I don’t have a ceiling lamp with moonlight to test. I will merge later today and release it if that’s ok with you. Regarding prettier, I have only used once or twice but I had a good experience with it. I can see that it will provide a better developer experience if it can automate away the effort of conforming to a code style, especially with developers coming from projects with different code styles, etc. |
|
I’ll introduce prettier then. You could add me at npm so I could do releases myself or we could automate the process with The semantic release. |
|
@okonet The help would be very welcome. I have added you as a collaborator in github and as a maintainer in npm. edit: I have released a new version that includes this new feature as v1.1.0. |
|
Hello guys! First of all, great work! I love all your hard work. However, something's wrong with this addition. I have Xiaomi Yeelight Meteorite (this to be exact https://www.gearbest.com/pendant-light/pp_009792951215.html) and the switch does not work. https://streamable.com/pxzh0 The switch does not control "the moonlight". Logs: https://pastebin.com/uk2HzGFT EDIT: Created the issue: #51 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds support for Yeelight Ceiling Lamp that supports "moonlight" mode.
It works by adding a separate switch accessory to an existing light so night mode can be controlled and automated separately from brightness. It takes advantage of HomeKit merging accessories of one device into one card.
Closes #46
Additionally, this PR adds lint-staged with automatic
eslint --fixscript to improve DX.It is still cumbersome to please it so I'm wondering if we could deprecate it in favor of prettier. I can match formatting settings in prettier config. I don't see any benefits of using eslint config for checking code style. WYT?