Scale HUD proportionally when resizing window #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijfhoek
requested changes
Oct 31, 2021
src/hud/widgets_hud.rs
Outdated
Comment on lines
30
to
31
| ui_scale_x: 0.0, | ||
| ui_scale_y: 0.0, |
There was a problem hiding this comment.
Perhaps it'd be nice to default these to the UI_SCALE_{X,Y} constants? That'll make sure that WidgetsHud is in an operable state right after new'ing it
There was a problem hiding this comment.
Trying to think of a way to only need to set the aspect ratio instead of scale_x and scale_y
There was a problem hiding this comment.
scale_x is just used in so many places and that would be replaced by scale_y / ratio which wouldn't actually work if we want to support the toolbar shrinking when the window width is too small. Currently I check if the toolbar would be clipped and then shrink it. We could just ignore that case
vijfhoek
reviewed
Nov 1, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a lot of debatable things in here, please roast.
scales well now, fixes #9