-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
📝 Use Entrypoint
style in example codes
#13
Conversation
WalkthroughThe updates involve upgrading the Denops plugin tutorial to use newer versions of dependencies, specifically moving from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Out of diff range and nitpick comments (1)
src/getting-started/explanation.md (1)
Line range hint
45-45
: Specify the language for the fenced code block.- ``` + ```typescript
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (14)
- src/getting-started/README.md (1 hunks)
- src/getting-started/explanation.md (3 hunks)
- src/tutorial.md (1 hunks)
- src/tutorial/helloworld/adding-an-api.md (1 hunks)
- src/tutorial/helloworld/calling-vim-features.md (2 hunks)
- src/tutorial/helloworld/creating-a-minimal-denops-plugin.md (1 hunks)
- src/tutorial/maze/adjusting-maze-size-to-fit-the-window.md (2 hunks)
- src/tutorial/maze/creating-applicative-plugin.md (1 hunks)
- src/tutorial/maze/outputting-content-to-buffer.md (2 hunks)
- src/tutorial/maze/properly-configured-the-buffer.md (2 hunks)
- src/tutorial/maze/properly-create-a-virtual-buffer.md (2 hunks)
- src/tutorial/maze/reduce-the-number-of-rpc-calls.md (2 hunks)
- src/tutorial/maze/utilizing-denops-std-library.md (2 hunks)
- src/tutorial/maze/utilizing-third-party-library.md (1 hunks)
Additional comments not posted (23)
src/tutorial/maze/outputting-content-to-buffer.md (2)
10-10
: Import statement updated to useEntrypoint
fromdenops_std@v6.5.0
.
Line range hint
13-22
: Function declaration updated to useEntrypoint
and the function body remains consistent with the tutorial's objective.src/tutorial.md (1)
9-11
: Version numbers updated todenops.vim v6.1.0
anddenops_std v6.5.0
.src/tutorial/helloworld/adding-an-api.md (2)
10-11
: Import statements updated to useEntrypoint
fromdenops_std@v6.5.0
andunknownutil@v3.18.1
.
13-20
: Function declaration updated to useEntrypoint
and the function body remains consistent with the tutorial's objective.src/getting-started/README.md (2)
25-25
: Import statement updated to useEntrypoint
fromdenops_std@v6.5.0
.
27-33
: Function declaration updated to useEntrypoint
and the function body remains consistent with the tutorial's objective.src/tutorial/helloworld/creating-a-minimal-denops-plugin.md (2)
35-35
: Import statement updated to useEntrypoint
fromdenops_std@v6.5.0
.
37-39
: Function declaration updated to useEntrypoint
and the function body remains consistent with the tutorial's objective.src/tutorial/helloworld/calling-vim-features.md (2)
8-9
: Import statements updated to useEntrypoint
fromdenops_std@v6.5.0
andunknownutil@v3.18.1
.
Line range hint
11-26
: Function declaration updated to useEntrypoint
and the function body remains consistent with the tutorial's objective.src/tutorial/maze/properly-configured-the-buffer.md (2)
10-13
: Import statements updated to useEntrypoint
and other modules fromdenops_std@v6.5.0
.
Line range hint
16-36
: Function declaration updated to useEntrypoint
and the function body remains consistent with the tutorial's objective.src/tutorial/maze/adjusting-maze-size-to-fit-the-window.md (2)
11-12
: Import statements updated to useEntrypoint
and other modules fromdenops_std@v6.5.0
.
Line range hint
15-31
: Function declaration updated to useEntrypoint
and the function body remains consistent with the tutorial's objective.src/tutorial/maze/utilizing-third-party-library.md (1)
35-43
: LGTM! The function declaration has been correctly updated to useEntrypoint
.src/tutorial/maze/creating-applicative-plugin.md (1)
Line range hint
43-57
: LGTM! The function declaration has been correctly updated to useEntrypoint
.src/tutorial/maze/properly-create-a-virtual-buffer.md (1)
Line range hint
18-35
: LGTM! The function declaration has been correctly updated to useEntrypoint
.src/tutorial/maze/utilizing-denops-std-library.md (1)
Line range hint
29-57
: LGTM! The function declaration has been correctly updated to useEntrypoint
.src/tutorial/maze/reduce-the-number-of-rpc-calls.md (1)
Line range hint
16-39
: LGTM! The function declaration has been correctly updated to useEntrypoint
.src/getting-started/explanation.md (3)
94-94
: LGTM! The import statement has been correctly updated to useEntrypoint
.
96-102
: LGTM! The function declaration has been correctly updated to useEntrypoint
.
Line range hint
110-154
: LGTM! The explanation has been correctly updated to reflect the newEntrypoint
type.
a33d798
to
3f1e49d
Compare
3f1e49d
to
dc106f1
Compare
dc106f1
to
e316b72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
Out of diff range and nitpick comments (2)
src/tutorial/helloworld/adding-an-api.md (2)
Line range hint
38-38
: Specify the language for the fenced code block.Specify the language for the fenced code block to improve syntax highlighting.
- ``` + ```typescript
Line range hint
44-44
: Add alternate text for the image.Add alternate text for the image to improve accessibility.
-  + 
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (16)
- .github/workflows/mdbook.yml (1 hunks)
- .github/workflows/test.yml (2 hunks)
- src/getting-started/README.md (1 hunks)
- src/getting-started/explanation.md (3 hunks)
- src/tutorial.md (1 hunks)
- src/tutorial/helloworld/adding-an-api.md (1 hunks)
- src/tutorial/helloworld/calling-vim-features.md (2 hunks)
- src/tutorial/helloworld/creating-a-minimal-denops-plugin.md (1 hunks)
- src/tutorial/maze/adjusting-maze-size-to-fit-the-window.md (2 hunks)
- src/tutorial/maze/creating-applicative-plugin.md (1 hunks)
- src/tutorial/maze/outputting-content-to-buffer.md (2 hunks)
- src/tutorial/maze/properly-configured-the-buffer.md (2 hunks)
- src/tutorial/maze/properly-create-a-virtual-buffer.md (2 hunks)
- src/tutorial/maze/reduce-the-number-of-rpc-calls.md (2 hunks)
- src/tutorial/maze/utilizing-denops-std-library.md (2 hunks)
- src/tutorial/maze/utilizing-third-party-library.md (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- src/tutorial/maze/outputting-content-to-buffer.md
- src/tutorial/maze/properly-configured-the-buffer.md
- src/tutorial/maze/reduce-the-number-of-rpc-calls.md
Additional comments not posted (23)
.github/workflows/test.yml (1)
9-10
: Ensure that the branches specified for the push event are correct and intended.Please confirm that the
main
branch is the only branch intended for this workflow.src/tutorial.md (1)
9-12
: Ensure the version updates are correct and the links are valid.Please verify that the versions
v6.0.7
fordenops.vim
andv6.5.0
fordenops_std
are correct and that the links point to the correct release pages.src/tutorial/helloworld/adding-an-api.md (2)
10-11
: Ensure the import statements are correct and the versions are updated.Please verify that the import statements for
Entrypoint
andunknownutil
are correct and that the versionsv6.5.0
andv3.18.1
are accurate.
13-20
: Ensure the function declaration is correct and follows the newEntrypoint
style.The function declaration has been correctly updated to use the
Entrypoint
style..github/workflows/mdbook.yml (1)
39-40
: Ensure the installation commands are correct and necessary.The installation commands for
mdbook
andmdbook-alerts
are correct and necessary for the workflow.src/getting-started/README.md (1)
25-33
: The changes to useEntrypoint
style are correct and consistent with the PR objectives.src/tutorial/helloworld/creating-a-minimal-denops-plugin.md (1)
35-39
: The changes to useEntrypoint
style are correct and consistent with the PR objectives.src/tutorial/helloworld/calling-vim-features.md (1)
Line range hint
8-26
: The changes to useEntrypoint
style are correct and consistent with the PR objectives.src/tutorial/maze/adjusting-maze-size-to-fit-the-window.md (1)
Line range hint
11-31
: The changes to useEntrypoint
style are correct and consistent with the PR objectives.src/tutorial/maze/utilizing-third-party-library.md (2)
32-33
: Import statements updated correctly.
35-43
: Function declaration updated correctly.src/tutorial/maze/creating-applicative-plugin.md (2)
36-41
: Import statements updated correctly.
Line range hint
43-57
: Function declaration updated correctly.src/tutorial/maze/properly-create-a-virtual-buffer.md (2)
13-15
: Import statements updated correctly.
Line range hint
18-35
: Function declaration updated correctly.src/tutorial/maze/utilizing-denops-std-library.md (2)
23-26
: Import statements updated correctly.
Line range hint
29-57
: Function declaration updated correctly.src/getting-started/explanation.md (6)
94-94
: Correctly updated the import statement to useEntrypoint
from the new version ofdenops_std
.
96-102
: Correctly updated the function declaration to use theEntrypoint
type and an arrow function.
110-110
: Correctly updated the explanation to reflect the new import statement.
113-122
: Correctly updated the explanation to reflect the new import statement and provide additional details.
138-154
: Correctly updated the note to reflect the newEntrypoint
type and provide additional details.
158-160
: Correctly updated the function declaration to use theEntrypoint
type and an arrow function.
Summary by CodeRabbit
denops.vim
(v6.1.0) anddenops_std
(v6.5.0).