Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do NOT check if corresponding mappings are already defined to define default mappings #27

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

lambdalisue
Copy link
Collaborator

@lambdalisue lambdalisue commented Jan 7, 2025

If we check whether the LHS exists in the mapping, users who remap <C-n> to something like <Up> would not have Fall’s default mappings defined, making it very inconvenient to use. Additionally, rather than checking if the RHS is already registered, we can allow users to define their mappings after the default mappings by setting the timing accordingly. This way, users can remove default mappings using <Nop>. Therefore, I modified the specification to add internal events such as ~System to enforce the timing.

@lambdalisue lambdalisue force-pushed the fix-default-mappings branch from e84ac63 to 7c06711 Compare January 7, 2025 14:00
Now default mappings are defined prior to user mappings so that user can
overwrite the default mappings if they want.
@lambdalisue lambdalisue force-pushed the fix-default-mappings branch from 7c06711 to e7e4455 Compare January 7, 2025 14:11
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.72%. Comparing base (51f9bf0) to head (e7e4455).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
denops/fall/util/emitter.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   80.67%   80.72%   +0.04%     
==========================================
  Files          24       24              
  Lines        1651     1655       +4     
  Branches      163      163              
==========================================
+ Hits         1332     1336       +4     
  Misses        316      316              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambdalisue lambdalisue merged commit 88c6ec5 into main Jan 7, 2025
5 of 6 checks passed
@lambdalisue lambdalisue deleted the fix-default-mappings branch January 7, 2025 14:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant