Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ci: fix windows download method #827

Merged
merged 1 commit into from
Dec 31, 2024
Merged

ci: fix windows download method #827

merged 1 commit into from
Dec 31, 2024

Conversation

tsuyoshicho
Copy link
Contributor

@tsuyoshicho tsuyoshicho commented Dec 31, 2024 •
edited
Loading

Summary

Windowsでのlua dllダウンロードエラーを修正します

Detail

Changes

  • CI でのダウンロードを WebClient から Invoke-WebRequest に変更、あわせて UserAgentを明記

    • WebRequest、HttpWebRequest、ServicePoint、WebClient は廃止されており、新しい開発には使用しないでください。 代わりに HttpClient を使用してください。

    • ここにあるように UserAgent 指定がないとエラーが出やすいみたいなので
    • 今回の動作のエラーも、UserAgent指定がないことが由来と思われます

Tests

CIを参照

@tsuyoshicho tsuyoshicho self-assigned this Dec 31, 2024
@tsuyoshicho tsuyoshicho marked this pull request as ready for review December 31, 2024 00:13
@tsuyoshicho
Copy link
Contributor Author

あまり問題ないはずですので、マージします

@tsuyoshicho tsuyoshicho merged commit a2d1509 into vim-jp:master Dec 31, 2024
16 checks passed
@tsuyoshicho tsuyoshicho deleted the fix/windowscierror branch December 31, 2024 02:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ujihisa ujihisa ujihisa approved these changes

@thinca thinca Awaiting requested review from thinca

Assignees

@tsuyoshicho tsuyoshicho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsuyoshicho @ujihisa