Support version up to Vim 9.1 and drop Vim 8.2. #828
+33
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujihisa
approved these changes
Dec 31, 2024
|
テストや実装の修正もありますので、そろったらまたレビューをおねがいします @ujihisa |
tsuyoshicho
commented
Jan 2, 2025
| @@ -10,25 +10,21 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest] | |||
| vim: [v8.2.0020, v9.0.0107, head] | |||
| vim: [v9.0.0107, v9.1.0100 ,head] | |||
There was a problem hiding this comment.
9.1.0000 は linux で色データのマッチが不正になってしまうので、9.1.0100 としました
- 現在 runtime/colors/lists/default.vim に色データはあります(lowercase)
- Color.vim は検索時にlowercaseに整理してして行います
- データとしてYellow(yellow)は常にありますが、失敗しています
問題が修正されたパッチを見付けれられなかったので、ほどほど後のバージョンをとりあえずで決めて入れています
see link
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vim 9.1 / 9.0 Support へ変更するPRです。
サポートバージョンの変更対応です。
対象バージョンが変化するため、CIでのrequiredで8.2はマージ後取り除き、9.1系を設定する必要があります。
(このPRでは8.2系は常にひっかかります)
変更として、必要最小の対応です。
いくつかの機能は高度化の可能性がありますが、それは別途個別に行います。