grpc: Convert key to a bytes field #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Galaxycache is perfectly fine with non-UTF-8 keys, but some go Protobuf library versions validate UTF-8 conformance when serializing string-fields. We can side-step this by setting the field definitions to conform to the protobuf spec by putting our possibly-not-utf-8 strings in a bytes field. Fortunately, string and bytes fields are 100% wire compatible, so switching the type only creates a mild API break. I doubt anyone's using these protobuf messages directly, so I'm just going to declare that they aren't covered by v1.x compatibility. Also, regenerate the protobuf types with the current protobuf library (google.golang.org/protobuf instead of github.com/golang/protobuf). Include a test to guarantee that this does the right thing with invalid UTF-8.
silvenac
approved these changes
Jun 15, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Galaxycache is perfectly fine with non-UTF-8 keys, but some go Protobuf library versions validate UTF-8 conformance when serializing string-fields.
We can side-step this by setting the field definitions to conform to the protobuf spec by putting our possibly-not-utf-8 strings in a bytes field.
Fortunately, string and bytes fields are 100% wire compatible, so switching the type only creates a mild API break.
I doubt anyone's using these protobuf messages directly, so I'm just going to declare that they aren't covered by v1.x compatibility.
Also, regenerate the protobuf types with the current protobuf library (google.golang.org/protobuf instead of github.com/golang/protobuf).
Include a test to guarantee that this does the right thing with invalid UTF-8.