This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Remove HSL input, add option to hide slider, update rgb input #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdebotton
reviewed
Oct 19, 2022
juliewongbandue
force-pushed
the
UXE-75-colorselect-hsl
branch
from
be3b184 to
a634bb8
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
hueSliderpropScreenshots & Recordings
Updated inputs to toggle HEX and RGB inputs, no HSL: https://vimeo.com/761984530/6487f7f396
RGB input before: https://vimeo.com/761962545/3e22c078db
After: https://vimeo.com/761966712/3ef1198ae3
Hide hue slider with
hueSlider = falseprop:Testing
Storybook: https://vimeo.github.io/iris/sb/UXE-75-colorselect-hsl/?path=/story/components-colorselect