This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Update toggle button and focus state #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliewongbandue
force-pushed
the
UXE-94-menu-focus-state-2
branch
4 times, most recently
from
7654cfa to
d50dcfc
Compare
Update syntax
juliewongbandue
force-pushed
the
UXE-94-menu-focus-state-2
branch
from
d50dcfc to
2799668
Compare
tylerthegrove
approved these changes
Nov 16, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Updates the focus state for the menu item
How it does that
Adds a
isKeyboardOnlyprop to the component and adds a:focus-visibleor:focuspseudo selector.Testing
Collapsible menu
Complex implementation
Confirm that tabbing/clicking focus states work as expected.