This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Add dragging to useLayoutEffect dependency array in Slider and add sl… #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliewongbandue
force-pushed
the
fix-slider
branch
from
b59d54a to
d3ccc31
Compare
tylerthegrove
approved these changes
Feb 13, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
draggingtouseLayoutEffectin Slider component to account for positioning in a popovermaxvalue to active range and handle style to account for max values > 100Screenshots & Recordings
Screen.Recording.2023-02-13.at.1.21.40.PM.mov
How it does that
draggingto dependency array ofuseLayoutEffectto watch for position oftrackRefTesting
See storybook: Confirm that dragging handle works as expected.