This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Prevent button props from being added to the DOM element #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenneth-duverge
had a problem deploying
to
development
GitHub Actions
Failure
kenneth-duverge
had a problem deploying
to
development
GitHub Actions
Failure
juliewongbandue
had a problem deploying
to
development
GitHub Actions
Failure
juliewongbandue
had a problem deploying
to
development
GitHub Actions
Failure
kenneth-duverge
temporarily deployed
to
development
GitHub Actions
Inactive
juliewongbandue
had a problem deploying
to
development
GitHub Actions
Error
kenneth-duverge
force-pushed
the
stop-prop-forwarding-button
branch
from
2702b1a to
d619b00
Compare
kenneth-duverge
had a problem deploying
to
development
GitHub Actions
Failure
kenneth-duverge
had a problem deploying
to
development
GitHub Actions
Failure
kenneth-duverge
force-pushed
the
stop-prop-forwarding-button
branch
from
d619b00 to
2239780
Compare
kenneth-duverge
temporarily deployed
to
development
GitHub Actions
Inactive
kenneth-duverge
force-pushed
the
stop-prop-forwarding-button
branch
from
2239780 to
e40b4f6
Compare
kenneth-duverge
force-pushed
the
stop-prop-forwarding-button
branch
from
e40b4f6 to
6a17936
Compare
kenneth-duverge
temporarily deployed
to
development
GitHub Actions
Inactive
juliewongbandue
approved these changes
May 17, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Cleans up our console!
Screenshots & Recordings
How it does that
Removes the
shouldForwardPropattribute as it was exposing other props as DOM attributes.Testing