This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Dsys 4 dsys 5 fix input events #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanbrud
force-pushed
the
DSYS-4-DSYS-5-fix-input-events
branch
from
96625c2 to
a150487
Compare
|
@juliewongbandue Hi Julie can u please take a look? Thanks! |
juliewongbandue
approved these changes
Jul 5, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Change / end events can be sent from 2 flows: handle move or input change.
This fixed an issue where changing the input would send an event without target (and without value) in single handle mode.
Screenshots & Recordings
Screen.Recording.2023-07-04.at.9.03.28.mov
How it does that
Check for what is focused, if it's input or handle and have a fallback for startHandle if something is missing.
Testing
Added unit tests for this specific flow to make sure we always get a target.