This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Support preact #74
Merged
Support preact #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdreetz
force-pushed
the
support-preact
branch
from
127bb9b to
9705d8e
Compare
seanmcintyre
suggested changes
Jan 21, 2022
package.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "name": "@vimeo/iris", | |||
| "homepage": "https://github.com/vimeo/iris/tree/main", | |||
| "bugs": "https://github.com/vimeo/iris/issues", | |||
| "version": "0.115.0", | |||
| "version": "0.115.0-preactsupport1", | |||
There was a problem hiding this comment.
@jdreetz could you please remove the version change so we can merge the PR?
seanmcintyre
force-pushed
the
support-preact
branch
from
20d2c16 to
718683d
Compare
…rops. We need to supply an empty argument for compatibility.
…utput of forwardRef and set the 87204iris property on it manually
seanmcintyre
force-pushed
the
support-preact
branch
from
718683d to
82458d7
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
While testing Iris with Preact, we discovered several incompatibilities that prevented proper rendering of Iris components. We've made the necessary adjustments to the Iris source to support Preact. I was able to test the entire Iris Storybook with Preact and there did not appear to be any regressions in functionality across components, but this should be verified with QA before merging.
Why
We're working on an update to Vimeo Player UI framework and are considering using Preact. One of the goals for the update is to incorporate Iris components in to the Vimeo player. Given that React and React-DOM are fairly large, we wanted to use Preact instead because of it's fast rendering and small library size.