This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Toggle panel when clicking on sidebar item #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Would love some thoughts on this PR. Makes a small update to the
togglefunction in theSidebar. Essentially a user would be able to toggle the panel by clicking the sidebar button. This is behavior needed with the collapsed navigation on SVV.( Which can be trigger by visiting the manage page and appending
?sn=trueto the url e.g https://vimeo.com/manage/videos/:videoid?sn=true ).How it does that
Checks to see if the current active panel is equal to the label of the button being clicked. If so, we close the panel