Import cgroup2 support & use generics to improve pparser's interface #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve type-safety by pulling in the recent changes making LineKVFileParser generic. This guarantees that the index that has been generated for one type cannot be used with another. This also lets us eliminate a runtime check that was verifying that the correct type was passed. (since that's now enforced at compile-time)
Add a subpackage for resolving the relevant cgroup for a process, and finding a usable cgroup mount for that subsystem. In particular, this provides the ability to remove the rather problematic docker libcgroup implementation from our dependency-set.
Replace runc/libcontainer with the new cgresolver package, and implement support for parsing the cgroup2 quota/usage files. (to its credit, cgroup2 does have a standardized format)
This helper simplifies a couple test-conditions.
Also, bump actions/setup-go and actions/checkout to the latest available. Also bump staticcheck.
dfinkel
force-pushed
the
import_cgroup2_and_type_changes_2024-12-06
branch
from
9918cc8 to
869f771
Compare
sergiosalvatore
approved these changes
Dec 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make pparser.LineKVFileParser generic and typesafe
Improve type-safety by pulling in the recent changes making
LineKVFileParser generic. This guarantees that the index that has been
generated for one type cannot be used with another.
This also lets us eliminate a runtime check that was verifying that the
correct type was passed. (since that's now enforced at compile-time)
cgresolver: cgroup2 & cgroup1 resolution support
Add a subpackage for resolving the relevant cgroup for a process, and
finding a usable cgroup mount for that subsystem.
In particular, this provides the ability to remove the rather
problematic docker libcgroup implementation from our dependency-set.
cgrouplimits: add cgroup2 support
Replace runc/libcontainer with the new cgresolver package, and implement
support for parsing the cgroup2 quota/usage files. (to its credit,
cgroup2 does have a standardized format)
Add an unexported .eq method to CPUTime
This helper simplifies a couple test-conditions.
actions: update to go 1.22/1.23
Also, bump actions/setup-go and actions/checkout to the latest
available.