Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use ramsey/composer-install action #10966

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented May 7, 2024

This action includes caching and everything else necessary for dependency installation.
https://github.com/ramsey/composer-install

As @GromNaN told me.

@szepeviktor szepeviktor marked this pull request as ready for review May 7, 2024 12:27
@GromNaN
Copy link
Contributor

GromNaN commented May 7, 2024

I'm not a maintainer, I wouldn't pretend to decide. But I think it's a good idea to simplify the CI maintenance.

Comment on lines -51 to +29
git ls-files | grep \\\.php$ | grep -v ^dictionaries/scripts/* | ./vendor/bin/parallel-lint --stdin
git ls-files -- '*.php' ':!:dictionaries/scripts/*' | ./vendor/bin/parallel-lint --stdin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an extra from the man page of git.

@weirdan
Copy link
Collaborator

weirdan commented May 7, 2024

Before merging this I'd like to see how it works on master. The important bit is COMPOSER_ROOT_VERSION to allow cyclic dependencies, and I don't think ramsey/composer-install can handle it when composer cannot figure out the version (like it happens on master).

@szepeviktor
Copy link
Contributor Author

Where should I add COMPOSER_ROOT_VERSION?

@weirdan
Copy link
Collaborator

weirdan commented May 7, 2024

I think you can't. But maybe composer got smarter over the years and this is no longer required - we'll know when you target this PR (or create a new one) to the master branch.

@szepeviktor
Copy link
Contributor Author

COMPOSER_ROOT_VERSION is currently present in several steps.

@weirdan
Copy link
Collaborator

weirdan commented May 7, 2024

It's missing at least in bcc workflow. If it works with composite actions, that is.

@szepeviktor
Copy link
Contributor Author

Added 🍏

@GromNaN GromNaN mentioned this pull request Sep 18, 2024
4 tasks
@szepeviktor
Copy link
Contributor Author

@danog Could you lend a click here too?

@danog
Copy link
Collaborator

danog commented Jan 20, 2025

Would you mind submitting this against master first

@szepeviktor szepeviktor changed the base branch from 5.x to master January 20, 2025 15:18
@szepeviktor
Copy link
Contributor Author

@danog Done 🍏

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants