Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove argc and argv elements from $_ENV #8666

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Nov 5, 2022

Fixes #8662

@weirdan weirdan requested a review from orklah November 5, 2022 19:21
@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 5, 2022
@weirdan
Copy link
Collaborator Author

weirdan commented Nov 5, 2022

@orklah the failures of tests/Internal/Codebase/InternalCallMapHandlerTest.php don't seem to have resulted from this change, as it fails on 4.x/PHP 8.1 both locally and in CI.

@orklah
Copy link
Collaborator

orklah commented Nov 5, 2022

Thanks Bruce! Glad to see you back!

Yeah, tests broke suddenly when 8.1.12 released a few days ago. I'm not sure why but it seems related to sql server and reflection on this extension.

@orklah orklah merged commit 0e1c638 into vimeo:4.x Nov 5, 2022
@weirdan
Copy link
Collaborator Author

weirdan commented Nov 5, 2022

I'm not sure why but it seems related to sql server and reflection on this extension.

Locally I'm getting a lot of failures with ssh2 extension.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still having problems with $_ENV
2 participants