Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor BuildTab UI and improve job management functionality #105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gcbaptista
Copy link

@gcbaptista gcbaptista commented Oct 12, 2024

This PR refactors the BuildTab UI and enhances the job management functionality in the village building system. The main changes include:

  1. UI Improvements:

    • Moved job management buttons (Top, Up, Down, Bottom, Delete, Delete All) from the context menu to the bottom of the JobsGrid for better visibility and ease of use.
    • Reorganized the layout of the BuildTab for a more effecient and intuitive user experience.
  2. Functionality Enhancements:

    • Added null checks in job management methods (Up, Down, Top, Bottom, Delete) to prevent actions on unselected items.
    • Improved error handling and user feedback for various operations.

These changes aim to improve the user experience when managing building jobs and provide a more robust and error-resistant implementation of the building management system.

image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use "is null"?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any special reason for place them in bottom instead together with import and export buttons ?

Copy link
Owner

@vinaghost vinaghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check my comment on .xaml and viewmodel file

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants