Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add custom table borders and column alignment #60

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

vihuna
Copy link
Contributor

@vihuna vihuna commented Sep 17, 2023

Allow some few customization options for table borders and column alignment.

  • For custom borders: adds classes border-<position> and heavy-border-<position>, being position one of the values, top, right, bottom, left.

  • For custom column alignment: adds classes l1-l12, c1-c12, r1-r12.

Allow some few customization options for table borders and column
alignment.

- For custom borders: adds classes `border-<position>` and
`heavy-border-<position>`, being `position` one of the values, `top`,
`right`, ´bottom´, `left`.
- For custom column alignment: adds classes `l1-l12`, `c1-c12`, `r1-r12`.
@vercel
Copy link

vercel bot commented Sep 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
latex-css ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 10:18pm

Copy link
Owner

@vincentdoerig vincentdoerig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the idea, it almost feels like using the tabular environment! Have a look at the few comments I made and let me know what you think

@vihuna
Copy link
Contributor Author

vihuna commented Sep 18, 2023

Some comments:

  • Because the name conventions, now I also don't like the class names for column aligment; what about something like this?: col-n-l, col-n-c, col-n-r, for n = 1, ..., and left, center, right.

  • Because the names have changed, the commit message is outdated. ¿Should I make a force push?

@vincentdoerig
Copy link
Owner

  • Yes I agree, using col-n-l, col-n-c, col-n-r would make sense
  • I'll squash and merge once complete and will add the description from your first commit message using the updated class names so no need for you to force push

@vincentdoerig vincentdoerig merged commit b2975d2 into vincentdoerig:master Sep 22, 2023
@vihuna vihuna deleted the custom-table-borders branch April 8, 2024 10:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants