Skip to content

Commit

Permalink
Publish dSYM to Maven when doing a release (facebook#38992)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#38992

This Diff publishes the Hermes dSYMs to Maven while doing a release.
These were missing and so the Stack traces can't be fully symbolicated when a crash occurs.

## Changelog:
[Internal] - Publish dSYM to Maven

Reviewed By: cortinico

Differential Revision: D48309198

fbshipit-source-id: a5514e544587daadd0a0d7614f25a30fccd16a5b
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Aug 15, 2023
1 parent 27c53dd commit 540c41b
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1950,7 +1950,8 @@ jobs:
mkdir -p ./packages/react-native/ReactAndroid/external-artifacts/artifacts/
cp $HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-debug.tar.gz ./packages/react-native/ReactAndroid/external-artifacts/artifacts/hermes-ios-debug.tar.gz
cp $HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-release.tar.gz ./packages/react-native/ReactAndroid/external-artifacts/artifacts/hermes-ios-release.tar.gz
cp $HERMES_WS_DIR/dSYM/Debug/hermes.framework.dSYM ./packages/react-native/ReactAndroid/external-artifacts/artifacts/hermes-framework-dSYM-debug.tar.gz
cp $HERMES_WS_DIR/dSYM/Release/hermes.framework.dSYM ./packages/react-native/ReactAndroid/external-artifacts/artifacts/hermes-framework-dSYM-release.tar.gz
- run_yarn
- build_packages
- attach_workspace:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,24 @@ val hermesiOSReleaseArtifact: PublishArtifact =
classifier = "hermes-ios-release"
}

// Those artifacts should be placed inside the `artifacts/hermes-*.framework.dSYM` location
val hermesDSYMDebugArtifactFile: RegularFile =
layout.projectDirectory.file("artifacts/hermes-framework-dSYM-debug.tar.gz")
val hermesDSYMDebugArtifact: PublishArtifact =
artifacts.add("default", hermesDSYMDebugArtifactFile) {
type = "tgz"
extension = "tar.gz"
classifier = "hermes-framework-dSYM-debug"
}
val hermesDSYMReleaseArtifactFile: RegularFile =
layout.projectDirectory.file("artifacts/hermes-framework-dSYM-release.tar.gz")
val hermesDSYMReleaseArtifact: PublishArtifact =
artifacts.add("default", hermesDSYMReleaseArtifactFile) {
type = "tgz"
extension = "tar.gz"
classifier = "hermes-framework-dSYM-release"
}

apply(from = "../publish.gradle")

publishing {
Expand All @@ -43,6 +61,8 @@ publishing {
artifactId = "react-native-artifacts"
artifact(hermesiOSDebugArtifact)
artifact(hermesiOSReleaseArtifact)
artifact(hermesDSYMDebugArtifact)
artifact(hermesDSYMReleaseArtifact)
}
}
}

0 comments on commit 540c41b

Please # to comment.