refactor(anime-dl): better error handling/processing #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handle errors better (delegate thrown errors to initial caller) * move constants to files * create locales file to strings & generated strings - avoid logic pollution & keeps things constant [#18]
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
handle errors better (delegate thrown errors to initial caller)
move consts to constants file
create anime-dl/locales file for strings & generated strings - avoid logic
pollution & keeps things constant
Related Issues
Motivation and Context
Cleaner errors, better reasoning. Moves constants to files for easier & more
transparent updating.
How To Test It?
Linux,MacOSv16.13.12021.12.27Steps:
Visual reference
No visual changes made
Checklist
v16.13.1