Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor/organize decryptors and provider #29

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

vinnyA3
Copy link
Owner

@vinnyA3 vinnyA3 commented Jun 18, 2022

Description

This separates gogoanime logic from the main entry point of the tool; the purpose is to provide the groundwork for adding more providers in the future. Additionally, decrypt/extractor logic was moved out of the main processing file for gogo. Finally, update cli version output to include tool name from pkg json.

Related Issues

  • NO ISSUE

Motivation and Context

To provide the groundwork for adding new providers. Also, to separate some
business logic.

How To Test It?

  • Environment: Linux, MacOS
  • Node Version: v16.13.1
  • YT-DLP Version: 2021.12.27 - Latest

Steps:

  • start tool (compile npm build, run tool node ./dist/bin/index)
  • ensure tool runs correctly: no module resolution errors, can download things

Visual reference

Checklist

  • I have tested on a supported environment: Linux
  • I have tested using the project's Node version: v16.13.1
  • [n/a] I have added tests to cover my changes.
  • [n/a] I have updated the documentation accordingly.

vinnyA3 added 2 commits June 18, 2022 15:01
This separates gogoanime logic from the main entry point of the tool.
The purpose is to provide the groundwork for adding more providers in
the future.  Additionally, decrypt/extractor logic was moved out of the
main processing file for gogo.
@vinnyA3 vinnyA3 force-pushed the refactor/organize-decryptors-and-provider branch from 9837947 to 2e4668c Compare June 18, 2022 19:02
@vinnyA3 vinnyA3 merged commit 5ac027a into master Jun 18, 2022
@vinnyA3 vinnyA3 deleted the refactor/organize-decryptors-and-provider branch June 18, 2022 19:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant