Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OpenSprinklerStationEntity.run() got an unexpected keyword argument 'continue_running_stations' #313

Closed
paranerd opened this issue Oct 1, 2024 · 2 comments

Comments

@paranerd
Copy link

paranerd commented Oct 1, 2024

I set up a Template Switch using the UI. It has an option to let stations run in parallel when being started manually. However the run() function doesn't actually seem to expect the option.

I'm assuming either the frontend or backend is wrong here. Does anyone have a clue?

@EdLeckert
Copy link
Collaborator

First of all, do not confuse continue_running_stations with running stations in parallel. All this parameter does is not stop already running stations--kind of. Depending on the order of the already running stations vs. the new stations, an already running station may be paused and pre-empted by the new one, but will be queued to continue later with whatever time is remaining. This is because the new list of run-times for all stations must be submitted in station order, so they will then run in station order.

In any case, what you have encountered is that the run service (action) takes different parameters depending on the chosen target entity. The continue_running_stations parameter only works when a controller is the target--not a program or station--and then only if index/seconds pairs are used.

I have submitted PR #314 to try to alleviate the confusion by eliminating the display of parameters that are not valid. It's a work in progress. In the meantime, leave off that parameter unless targeting a controller.

@paranerd
Copy link
Author

paranerd commented Oct 7, 2024

Thanks for the in depth analysis!
I can confirm that my stations can run in parallel regardless of the setting.

@paranerd paranerd closed this as completed Oct 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants