Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of an earlier effort to simplify and clarify action (service) calling. That effort limited the available entities presented by the UI to only those appropriate to the action. This PR was inspired by Issue #313 and is intended to reduce the available selection of parameters available in the UI to the
run
action depending on the use case.It has become clear that the only way to effectively do this was to split the
run
action into multiple actions, one for each type of target entity. This is due to the fact that each entity type (controller, station, and program) takes a different set of parameters:run_seconds
andcontinue_running_stations
, onlyrun_seconds
, and no parameters, respectively.Therefore, I have added these new actions:
run_once
run_station
run_program
I have left the
run
service as-is (with one exception--see below), with the hope that it can be deprecated and removed in the future.I also noticed that the logic for
continue_running_stations
was reversed, so that has been corrected. This could be considered a breaking change, but is the only one.Finally, I have updated the docs (except for non-"en" translations), probably more than I had intended, but I wanted the existing examples to be consistent with the new ones.
I realize this is a bit to take in. Let me know your thoughts.