Fixes for Django 1.8 / Python 2.7: #12

trevoriancox · 2016-08-03T01:21:31Z

CACHES default overwrites settings.py.
HttpResponseNotModified does not accept mimetime parameter.

- CACHES default overwrites settings.py. - HttpResponseNotModified does not accept mimetime parameter.

vinyll · 2016-08-06T23:40:59Z

imagefit/views.py

@@ -41,7 +41,7 @@ def resize(request, path_name, format, url):
    statobj = os.stat(image.path)
    if not was_modified_since(request.META.get('HTTP_IF_MODIFIED_SINCE'),
                              statobj[stat.ST_MTIME], statobj[stat.ST_SIZE]):
-        return HttpResponseNotModified(mimetype=image.mimetype)
+        return HttpResponseNotModified() #mimetype=image.mimetype)


Could you remove the comment #mimetype=image.mimetype) here?
If we get rid of it let's just clear it out

Fixes for Django 1.8 / Python 2.7:

b4149e2

- CACHES default overwrites settings.py. - HttpResponseNotModified does not accept mimetime parameter.

vinyll reviewed Aug 6, 2016
View reviewed changes

egon0 added a commit to egon0/django-imagefit that referenced this pull request Nov 5, 2016

HttpResponseNotModified does not accept mimetime parameter. @vinyll#12

3543708

vinyll force-pushed the master branch 2 times, most recently from 0a17394 to 7b8b1b1 Compare September 7, 2023 21:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for Django 1.8 / Python 2.7: #12

Fixes for Django 1.8 / Python 2.7: #12

trevoriancox commented Aug 3, 2016

vinyll Aug 6, 2016

Fixes for Django 1.8 / Python 2.7: #12

Are you sure you want to change the base?

Fixes for Django 1.8 / Python 2.7: #12

Conversation

trevoriancox commented Aug 3, 2016

vinyll Aug 6, 2016

Choose a reason for hiding this comment