Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add https:// to URL when the inputted URL is without https:// #9

Merged

Conversation

kazuhitonakayama
Copy link
Contributor

@kazuhitonakayama kazuhitonakayama commented Sep 2, 2021

Issue

#7

Overview

Add https:// to URL only when the inputted URL is without https://

Intention

It would be easier to search if you could just enter the URL of the domain only.

@kazuhitonakayama
Copy link
Contributor Author

kazuhitonakayama commented Sep 2, 2021

I hope you will review this when you have time! :)
@virejdasani

@virejdasani
Copy link
Owner

virejdasani commented Sep 2, 2021

Hi @kazuhitonakayama, this looks awesome! However, when reviewing I noticed that although the website that gets loaded has the https:// prefix, the url input box stays without the https://

Screenshot 2021-09-02 at 8 15 37 AM

If you add this line:

document.querySelector("#urlInput").value = website

in the goButton.addEventListener, under this:

normalizedUrl = normalizeUrl(inputtedUrl)
website = normalizedUrl

Then the https:// will automatically get added to the search bar

Screenshot 2021-09-02 at 8 16 33 AM

I'll go ahead with the merge once you have made these changes :)

@kazuhitonakayama
Copy link
Contributor Author

@virejdasani
Oh, sorry I missed it .. :(
I will fix it !
Thank you for your review :)

@kazuhitonakayama
Copy link
Contributor Author

@virejdasani
Hi, I made some changes :)
kazuhitonakayama@937315f
kazuhitonakayama@d7e06b6

I would like you to review this PR when you have time 👍

@virejdasani
Copy link
Owner

Hi @kazuhitonakayama, thanks a lot for contributing! It works perfectly :)

@virejdasani virejdasani merged commit 5fc6e53 into virejdasani:master Sep 3, 2021
@kazuhitonakayama
Copy link
Contributor Author

Thank you for you to make awesome app, Responsivize:)

@virejdasani
Copy link
Owner

Thank you for you to make awesome app, Responsivize:)

I'm glad you liked it!

@virejdasani virejdasani added the Bug(s) squashed! A pesky bug has been stomped on! label Oct 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug(s) squashed! A pesky bug has been stomped on!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants