Leaderboard #855

sgfost · 2023-03-28T21:36:23Z

Adds global high scores and personal game history pages

resolves #852
resolves #851

Co-authored-by: Allen Lee <alee@users.noreply.github.com> Co-authored-by: saachibm <saachibm@users.noreply.github.com>

created leaderboard.ts in server/src/routes section for issue virtualcommons#851 and added b-table in Leaderboard.vue for virtualcommons#852

Issue virtualcommons#852 created table and added table components + ordered rank in ascending order

Issue virtualcommons#851 tried to do AJAX handling requests and see bot/non-bot data

Issue virtualcommons#852 Added bot/non-bot buttons (tried to link button to a function that retrieves data) and reconfigured containers for vertical view

Co-authored-by: saachibm <saachibm@users.noreply.github.com> ref virtualcommons#851 feat: improve leaderboard view styling/functionality - added fetch on create - reworked styling to be more consistent - added filter switch ref virtualcommons#852 Co-authored-by: saachibm <saachibm@users.noreply.github.com> feat: add leaderboard service highscore queries ref virtualcommons#851

Issue virtualcommons#852 Started connecting button to client data (and went over code in Leaderboard.ts)

issue virtualcommons#852 and virtualcommons#851 setup TODO and FIXME for requirements LiveShare VSC with Scott, Saachi, and I

Issue virtualcommons#852 - Added the rest of leaderboard item fields - Added sortable to leaderboard fields (rank & username) - Squashed 2 commits and reconfigured Tiffany's local repository Co-Authored-By: Tiffany Kawamura <86638759+Tkawamura02@users.noreply.github.com>

sgfost · 2023-03-28T21:39:44Z

Looking this over again, it seems like commit history got a bit mangled (probably by github desktop) with a merge creating duplicate commits, easily fixable but ought to be done before merging this

Also: get in the habit of using semantic commit messages, helps out with consistency so our future selves can figure out what happened

- added fetch on create - reworked styling to be more consistent - added filter switch ref virtualcommons#852 Co-authored-by: saachibm <saachibm@users.noreply.github.com> Co-authored-by: Tkawamura02 <Tkawamura02@users.noreply.github.com>

uses the old service and component that was used for the player dashboard TODO: - rework/restyle the PlayerStatItem component and the parent page Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com> Co-authored-by: saachibm <saachibm@users.noreply.github.com>

Tkawamura02 · 2023-04-06T00:53:17Z

UPDATED TASKS FOR THIS ISSUE

1. fix any corner cases / bugs in the query logic that are causing the current leaderboard issues with the null points
2. Ensure that the only games ending in success count in the points total for a given player
3. Embed a short summary leaderboard view in the landing page as a contrasting section (after Gameplay?). This would only include the top 10 players and could be parameterizable Prop for the component
4. Minor styling improvements as needed

saachibm · 2023-04-06T02:12:27Z

UPDATED TASKS FOR THIS ISSUE

1. fix any corner cases / bugs in the query logic that are causing the current leaderboard issues with the null points

2. Ensure that the only games ending in success count in the points total for a given player

3. Embed a short summary leaderboard view in the landing page as a contrasting section (after Gameplay?). This would only include the top 10 players and could be parameterizable Prop for the component

4. Minor styling improvements as needed

Tiffany and I worked on task 2 and are continuing to figure out how to fix null points/corner cases (4/5/23)

- fixed issue with returning records with null points - only sum points from games with status=victory - added limit param to request Co-authored-by: saachibm <saachibm@users.noreply.github.com> Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com>

- extract leaderboard table into component, used by page/anywhere else - rework some of the displayed data for (hopefully) better clarity - restyling Co-authored-by: saachibm <saachibm@users.noreply.github.com> Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com>

[no ci]

sgfost · 2023-04-08T00:28:51Z

Just need to clean up the player stats/past games page for this to be ready to merge

Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com> Sabrina Nelson <sabrinanel3@users.noreply.github.com>

brought more in line with current styling and some refactoring on client/server Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com> Co-authored-by: saachibm <saachibm@users.noreply.github.com>

- add visually cliched table striping for contrast - use _rowVariant to highlight highest point players

TODO: should consider renaming leaderboard route to stats with /leaderboard /player endpoints instead

add clarification tooltip to victory % TODO: we should also add actual victories, the number of games where all players survived and the player had the most victory points.

- mount .prettierrc into client and server containers so yarn style:fix should now work - merge staging.base.yml into staging.yml, the docker ports added in staging.yml are also used in prod

alee

Overall everything looks great but see the comments inline. Also I think there may be a bug in the player stats code (see screenshot) - the code in LeaderboardService looks OK though so I'm not exactly sure where it may be arising from.

client/src/views/Home.vue

client/src/views/PlayerStats.vue

alee · 2023-04-21T04:09:05Z

server/src/routes/leaderboard.ts

+
+export const leaderboardRouter = Router();
+
+leaderboardRouter.get("/", async (req, res, next) => {


feels like leaderboard is a part of /stats, not the other way around. how about routes like:

/stats/leaderboard /stats/player

No need to address in this PR, but we might want to create an issue for this to be resolved later

Ended up resolving this alongside the other renaming, stats is now the base url/service name/category for directory naming purposes

Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com>

- leaderboard (as a categorization) is now stats - player stats is now game history Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com>

sgfost · 2023-04-21T22:58:11Z

Should be good to go @alee, anything not addressed in the last couple of commits are in new issues

extract seems unnecessarily long

alee

LGTM thanks all!

alee · 2023-05-03T18:30:39Z

@all-contributors
please add @sgfost for mentoring, code, doc, and design.
please add @Tkawamura02 for code, doc, and design.
please add @saachibm for code, doc, and design.

allcontributors · 2023-05-03T18:33:12Z

@alee

I've put up a pull request to add @sgfost! 🎉

I've put up a pull request to add @Tkawamura02! 🎉

I've put up a pull request to add @saachibm! 🎉

sgfost and others added 9 commits February 28, 2023 16:02

feat(WIP): add leaderboard page skeleton

2a91270

Co-authored-by: Allen Lee <alee@users.noreply.github.com> Co-authored-by: saachibm <saachibm@users.noreply.github.com>

Start of leaderboard

a9ca1ea

created leaderboard.ts in server/src/routes section for issue virtualcommons#851 and added b-table in Leaderboard.vue for virtualcommons#852

Added b-table to Leaderboard.vue

2b9fd06

Issue virtualcommons#852 created table and added table components + ordered rank in ascending order

Created LeaderboardAPI with AJAX

80c377e

Issue virtualcommons#851 tried to do AJAX handling requests and see bot/non-bot data

Added b-button to Leaderboard.vue

03f3871

Issue virtualcommons#852 Added bot/non-bot buttons (tried to link button to a function that retrieves data) and reconfigured containers for vertical view

Reworked on bot checkbox

fc875d7

Issue virtualcommons#852 Started connecting button to client data (and went over code in Leaderboard.ts)

Todo and meeting updates

74d1b0c

issue virtualcommons#852 and virtualcommons#851 setup TODO and FIXME for requirements LiveShare VSC with Scott, Saachi, and I

sgfost assigned Tkawamura02 and saachibm Mar 28, 2023

sgfost and others added 2 commits March 31, 2023 15:02

Tkawamura02 force-pushed the leaderboard-feat branch from d7008d2 to ecaeeb1 Compare March 31, 2023 22:22

Update sortable

ea8526a

sgfost and others added 3 commits April 7, 2023 16:36

chore: add text to landing page community blurb

aa312be

[no ci]

saachibm and others added 2 commits April 12, 2023 19:34

Reformatted date and layout of player stats

a8cbc25

Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com> Sabrina Nelson <sabrinanel3@users.noreply.github.com>

refactor: rehaul player stats/previous games ui

17321a6

brought more in line with current styling and some refactoring on client/server Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com> Co-authored-by: saachibm <saachibm@users.noreply.github.com>

sgfost marked this pull request as ready for review April 17, 2023 18:13

alee added 4 commits April 20, 2023 13:18

refactor: minor style changes and variable renaming

d24a11d

- add visually cliched table striping for contrast - use _rowVariant to highlight highest point players

refactor: rename copypasta variables

636b999

TODO: should consider renaming leaderboard route to stats with /leaderboard /player endpoints instead

fix(build): escape typescript bondage

405ad00

add clarification tooltip to victory % TODO: we should also add actual victories, the number of games where all players survived and the player had the most victory points.

fix(build): enable yarn style:fix

fb3de05

- mount .prettierrc into client and server containers so yarn style:fix should now work - merge staging.base.yml into staging.yml, the docker ports added in staging.yml are also used in prod

alee requested changes Apr 21, 2023

View reviewed changes

alee and others added 3 commits April 20, 2023 23:47

fix(style): minor hygiene

e3a0514

fix: player history assigning wrong winners

994f02f

Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com>

refactor: rename and re-organize leaderboard/game history

278b82c

- leaderboard (as a categorization) is now stats - player stats is now game history Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com>

sgfost mentioned this pull request Apr 21, 2023

Add redirect param to login route #857

Open

rename: extract -> get

2ee680e

extract seems unnecessarily long

alee approved these changes Apr 22, 2023

View reviewed changes

alee merged commit c666a68 into virtualcommons:main Apr 22, 2023

This was referenced May 3, 2023

docs: add sgfost as a contributor for mentoring, code, and 2 more #861

Closed

docs: add Tkawamura02 as a contributor for code, doc, and design #862

Merged

docs: add saachibm as a contributor for code, doc, and design #863

Merged

alee mentioned this pull request Oct 28, 2023

add "Hall of Champions" page #656

Closed

alee deleted the leaderboard-feat branch December 7, 2023 21:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Leaderboard #855

Leaderboard #855

sgfost commented Mar 28, 2023

sgfost commented Mar 28, 2023 •

edited

Loading

Tkawamura02 commented Apr 6, 2023 •

edited by sgfost

Loading

saachibm commented Apr 6, 2023

sgfost commented Apr 8, 2023

alee left a comment

alee Apr 21, 2023

sgfost Apr 21, 2023

sgfost commented Apr 21, 2023

alee left a comment

alee commented May 3, 2023 •

edited

Loading

allcontributors bot commented May 3, 2023


		export const leaderboardRouter = Router();

		leaderboardRouter.get("/", async (req, res, next) => {

Leaderboard #855

Leaderboard #855

Conversation

sgfost commented Mar 28, 2023

sgfost commented Mar 28, 2023 • edited Loading

Tkawamura02 commented Apr 6, 2023 • edited by sgfost Loading

saachibm commented Apr 6, 2023

sgfost commented Apr 8, 2023

alee left a comment

Choose a reason for hiding this comment

alee Apr 21, 2023

Choose a reason for hiding this comment

sgfost Apr 21, 2023

Choose a reason for hiding this comment

sgfost commented Apr 21, 2023

alee left a comment

Choose a reason for hiding this comment

alee commented May 3, 2023 • edited Loading

allcontributors bot commented May 3, 2023

sgfost commented Mar 28, 2023 •

edited

Loading

Tkawamura02 commented Apr 6, 2023 •

edited by sgfost

Loading

alee commented May 3, 2023 •

edited

Loading