-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Account fixes #859
Merged
Merged
Account fixes #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somewhere along the line this got removed/broken and led to the same order of roles being assigned for every game
currently at max 30 chars and alphanumeric + underscores for usernames
Co-authored-by: Allen Lee <alee@users.noreply.github.com>
extracting the registration process into 2 pages with the second being used for editing profile fields afterwards TODO: create the profile page with the existing form, add redirects [no ci] Co-authored-by: Allen Lee <alee@users.noreply.github.com>
separation between the two was becoming unclear
consolidated request methods client side and refactoring how requests are handled server-side
[no ci] - missing test corrections
use the content background color that is used for every other page [no ci]
Should be good to go here @alee |
remove typeorm migration in dangerously-resetdb so dangerously-loaddb can work properly
alee
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solid work, LGTM! a few minor comments inline
push toClientSafeUser call inside guard, otherwise first anonymous hit to the landing page generates errors use log %o syntax to emit the user details instead of [object Object]
- continuation of consolidating auth/account services/routes - added checkbox for dev login with/without auto verification
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements various fixes/improvements mostly related to accounts