Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Account fixes #859

Merged
merged 17 commits into from
Apr 29, 2023
Merged

Account fixes #859

merged 17 commits into from
Apr 29, 2023

Conversation

sgfost
Copy link
Contributor

@sgfost sgfost commented Apr 26, 2023

Implements various fixes/improvements mostly related to accounts

  • resolves virtualcommons/planning#35
  • resolves virtualcommons/planning#36
  • resolves virtualcommons/planning#37

sgfost and others added 7 commits April 26, 2023 13:46
somewhere along the line this got removed/broken and led to the same
order of roles being assigned for every game
currently at max 30 chars and alphanumeric + underscores for usernames
Co-authored-by: Allen Lee <alee@users.noreply.github.com>
extracting the registration process into 2 pages with the second
being used for editing profile fields afterwards

TODO: create the profile page with the existing form, add redirects

[no ci]

Co-authored-by: Allen Lee <alee@users.noreply.github.com>
sgfost added 6 commits April 27, 2023 10:39
separation between the two was becoming unclear
consolidated request methods client side and refactoring how requests
are handled server-side
[no ci] - missing test corrections
use the content background color that is used for every other page

[no ci]
@sgfost sgfost marked this pull request as ready for review April 27, 2023 23:02
@sgfost
Copy link
Contributor Author

sgfost commented Apr 27, 2023

Should be good to go here @alee

remove typeorm migration in dangerously-resetdb so dangerously-loaddb
can work properly
Copy link
Member

@alee alee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid work, LGTM! a few minor comments inline

alee and others added 3 commits April 28, 2023 09:39
push toClientSafeUser call inside guard, otherwise first anonymous hit
to the landing page generates errors

use log %o syntax to emit the user details instead of [object Object]
- continuation of consolidating auth/account services/routes

- added checkbox for dev login with/without auto verification
@alee alee merged commit fd3c467 into virtualcommons:main Apr 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants