Add a free vector tile services to avoid the usage of a token #5079

Josmorsot · 2020-10-28T18:02:51Z

This PR adds CARTO free vector tile services to avoid the usage of a mapboxApiAccessToken in all the examples.

Update all the examples: remove mapboxApiAccessToken and add CARTO basemap
Add CARTO basemap service at the doc https://deck.gl/docs/get-started/using-with-map
Update website
Create a new style to match website examples with the current version.
Remove mapboxApiAccessToken token from tests

…van/carto-basemaps

examples/gallery/build-tools/constants.js

website/src/examples/carto.js

website/src/constants/defaults.js

Pessimistress · 2020-10-28T18:32:05Z

As discussed, the example READMEs should add a section "Map style" and link to https://deck.gl/docs/get-started/using-with-map

alasarr

The most important, add a description to the PR

examples/gallery/src/mapbox-layer.html

examples/get-started/pure-js/mapbox/webpack.config.js

examples/website/scenegraph/app.js

modules/carto/src/basemap.js

alasarr · 2020-10-28T19:11:32Z

As discussed, the example READMEs should add a section "Map style" and link to https://deck.gl/docs/get-started/using-with-map

Yes, I agreed with @Josmorsot I'll add this part.

Josmorsot · 2020-10-28T20:25:12Z

The most important, add a description to the PR

Done 👍 Apologies for that.

examples/experimental/h3-grid/webpack.config.js

examples/get-started/pure-js/mapbox/webpack.config.js

docs/get-started/using-with-map.md

…van/carto-basemaps

alasarr

Cartography is almost there, but I see some differences with the building:

Could you check?

docs/api-reference/carto/basemap.md

examples/website/terrain/webpack.config.js

alasarr · 2020-10-30T11:54:28Z

If possible, try to reduce the number of commits.

docs/get-started/using-with-map.md

alasarr

Check the boundaries of the first admin region. It looks roads appears before than prod.

alasarr

All the issues related to cartography are passed.

I've successfully tested (with gatsby):

All the website examples (layers, integrations, extensions)
Experimentals
Playground
Layer browser

Co-authored-by: Alberto Asuero <albertoasuero@gmail.com>

Iván Moreno and others added 12 commits October 28, 2020 12:44

replace mapbox light basemap with positron

c400861

replace mapbox dark basemap with dark-matter

51256d8

replace mapbox light basemap with positron

0be06bb

replace mapbox dark basemap with dark-matter

df13054

Gatsby and remove mapbox doc in arc

8651014

Remove token info from doc

ee04a30

Merge branch 'ivan/carto-basemaps' of github.com:visgl/deck.gl into i…

f8f18db

…van/carto-basemaps

change basemaps for examples

32cb2ea

change basemap url to staging

9c303ab

remove EnvPlugin from webpack-config

b585353

change basemap to prod version

47f3cef

minor changes

09aaa64

Josmorsot requested a review from alasarr October 28, 2020 18:02

Josmorsot marked this pull request as ready for review October 28, 2020 18:04

Josmorsot changed the title ~~Ivan/carto basemaps~~ Changing basemaps for examples Oct 28, 2020

Josmorsot changed the title ~~Changing basemaps for examples~~ Change basemaps for examples Oct 28, 2020

alasarr reviewed Oct 28, 2020

View reviewed changes

examples/gallery/build-tools/constants.js Outdated Show resolved Hide resolved

Pessimistress reviewed Oct 28, 2020

View reviewed changes

website/src/examples/carto.js Outdated Show resolved Hide resolved

website/src/constants/defaults.js Outdated Show resolved Hide resolved

alasarr suggested changes Oct 28, 2020

View reviewed changes

Add CARTO basemaps as a free tile service

0e47ba2

Josmorsot changed the title ~~Change basemaps for examples~~ Add a free vector tile services to avoid the usage of a token Oct 28, 2020

alasarr suggested changes Oct 28, 2020

View reviewed changes

examples/experimental/h3-grid/webpack.config.js Show resolved Hide resolved

examples/get-started/pure-js/mapbox/webpack.config.js Show resolved Hide resolved

More texts to usign-with-map doc

31190af

Pessimistress reviewed Oct 29, 2020

View reviewed changes

docs/get-started/using-with-map.md Outdated Show resolved Hide resolved

Iván Moreno added 3 commits October 29, 2020 08:56

fix lint

dbebf57

remove useless comments

0a4942e

Merge branch 'ivan/carto-basemaps' of github.com:visgl/deck.gl into i…

97581fb

…van/carto-basemaps

Iván Moreno and others added 13 commits October 30, 2020 11:55

fixes in mapbox example

7597ce4

added new dark/light mapstyles

f98a1a6

update basemaps

01b879e

getting style from constants

476f85d

update README's

0d7f3c5

change link, redirect to website instead of github doc

0f0a6aa

move basemaps doc to carto module

c001335

added basemap info to readme

f5d8f17

Changing texts at using-with-map.md

3f2e2be

Update readme link

12cdfa1

minor fixes in basemaps

47d06c6

Merge branch 'ivan/carto-basemaps' of github.com:visgl/deck.gl into i…

d69c1ad

…van/carto-basemaps

basemaps: added runway and taxiway

e6451bb

Josmorsot requested a review from alasarr October 30, 2020 11:21

alasarr suggested changes Oct 30, 2020

View reviewed changes

docs/api-reference/carto/basemap.md Outdated Show resolved Hide resolved

examples/website/terrain/webpack.config.js Outdated Show resolved Hide resolved

Iván Moreno added 3 commits October 30, 2020 13:20

update basemaps, added buildings and minor roads

2026b46

change text in basemap.md

1a8f735

fix: terrain example need token

db216aa

Josmorsot requested a review from alasarr October 30, 2020 12:39

Pessimistress reviewed Oct 30, 2020

View reviewed changes

docs/get-started/using-with-map.md Outdated Show resolved Hide resolved

alasarr suggested changes Oct 30, 2020

View reviewed changes

Iván Moreno added 2 commits October 30, 2020 15:54

minor fix in basemaps

af724d5

update basemaps doc

3a8a674

Josmorsot requested a review from alasarr October 30, 2020 16:17

alasarr approved these changes Oct 30, 2020

View reviewed changes

Pessimistress merged commit 67c347a into master Oct 30, 2020

Pessimistress deleted the ivan/carto-basemaps branch October 30, 2020 23:57

Pessimistress mentioned this pull request Oct 31, 2020

Misc fixes of mapstyle in examples #5086

Merged

Pessimistress pushed a commit that referenced this pull request Oct 31, 2020

Add a free vector tile services to avoid the usage of a token (#5079)

48ba388

Co-authored-by: Alberto Asuero <albertoasuero@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a free vector tile services to avoid the usage of a token #5079

Add a free vector tile services to avoid the usage of a token #5079

Josmorsot commented Oct 28, 2020 •

edited

Loading

Pessimistress commented Oct 28, 2020

alasarr left a comment

alasarr commented Oct 28, 2020

Josmorsot commented Oct 28, 2020

alasarr left a comment

alasarr commented Oct 30, 2020

alasarr left a comment •

edited

Loading

alasarr left a comment

Add a free vector tile services to avoid the usage of a token #5079

Add a free vector tile services to avoid the usage of a token #5079

Conversation

Josmorsot commented Oct 28, 2020 • edited Loading

Pessimistress commented Oct 28, 2020

alasarr left a comment

Choose a reason for hiding this comment

alasarr commented Oct 28, 2020

Josmorsot commented Oct 28, 2020

alasarr left a comment

Choose a reason for hiding this comment

alasarr commented Oct 30, 2020

alasarr left a comment • edited Loading

Choose a reason for hiding this comment

alasarr left a comment

Choose a reason for hiding this comment

Josmorsot commented Oct 28, 2020 •

edited

Loading

alasarr left a comment •

edited

Loading