-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for vtk 94 #20155
Draft
biagas
wants to merge
14
commits into
develop
Choose a base branch
from
task/biagas/vtk_94
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add support for vtk 94 #20155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be useful for debugging VTK-9.4 runtime choosing of the render window type.
Turns a vtkWarningMacro into a vtkDebugMacro to avoid user confusion. When vtk-9.4 chooses a render window on linux, it first tries vtkXOpenGLRenderWindow, and the warning is printed to the terminal when it cannot be used, but it isn't an error, it just means a different renderwindow type will be chosen.
… into task/biagas/vtk_94
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for VTK-9.4.
QUESTIONS
When building on LC, we get GLVND OpenGL, and EGL so offscreen rendering is using EGL (it is tried before OSMesa).
If we keep this default, then most (if not all) of our regression test baselines will need to be redone.
Ensuring OSMesa is used instead:
Either way we need to build OSMesa to ensure it is available if needed.
We currently have an opengl-context-check in build_visit to alert when MesaGL might be needed. This isn't valid with VTK-9.4 because the check uses libGL and VTK -9.4 needs libOpenGL. Should the test be updated? How so?
Is there a different way to know if MesaGL will be needed?
Do we still need the specialized vtkVisItStructuredGrid and vtkVisItRectilinearGrid (visit_vtk/full)? I removed them from the build for VTK-9.4. They need to be updated if still needed.
Resolves #
Type of change
How Has This Been Tested?
Reminders:
Checklist: