feat(timeline): add markers to custom time bars #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojoaxel
requested changes
Sep 12, 2019
docs/graph2d/index.html
Outdated
| @@ -1225,6 +1225,16 @@ <h2 id="Methods">Methods</h2> | |||
| </td> | |||
| </tr> | |||
|
|
|||
| <tr> | |||
There was a problem hiding this comment.
CustomTime is a timeline feature. This docs should be added here instead: https://github.com/visjs/vis-timeline/blob/master/docs/timeline/index.html#L1554
There was a problem hiding this comment.
Thank you for the review.
Fixed in 9eac76f.
There was a problem hiding this comment.
I've fixed commit messages and this PR's title as well.
ryamaguchi0220
changed the title
ryamaguchi0220
changed the title
mojoaxel
approved these changes
Sep 12, 2019
|
@ryamaguchi0220 Thanks again for you first contribution 🥇 |
Glandos
added a commit
to Glandos/vue2vis
that referenced
this pull request
Jul 27, 2021
It was introduced in visjs/vis-timeline#86
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84 .
Demo
https://visjs.github.io/vis-timeline/examples/timeline/markers/customTimeMarkers.html