Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(plugin-vue): don't inline template when __VUE_PROD_DEVTOOLS__ #81

Merged
merged 2 commits into from
May 30, 2024

Conversation

blakjak44
Copy link
Contributor

@blakjak44 blakjak44 commented Jan 8, 2023

Description

Ensure that the setup section is available in Vuejs Devtools when building with __VUE_PROD_DEVTOOLS__: true.

Additional context

Original fix. Possible regression since then? vitejs/vite#4984
Another report with example reproduction: https://github.com/vuejs/devtools/issues/1940

Not sure if defineExpose is supposed to play a role here.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@adamdehaven
Copy link

Is there any plan to merge this fix?

@CreeTar
Copy link

CreeTar commented Apr 3, 2024

can we get a comment for this issues anniversary? hope 2 months is enough ;)

@sxzz sxzz changed the title fix: make setup script compilation respect __VUE_PROD_DEVTOOLS__ fix(plugin-vue): don't inline template when __VUE_PROD_DEVTOOLS__ May 30, 2024
@sxzz sxzz merged commit 277a3ab into vitejs:main May 30, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants