Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(proxy): Include URL of request in proxy errors #10508

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Conversation

fc
Copy link
Contributor

@fc fc commented Oct 18, 2022

Description

Resolves this issue
#10507

Additional context

Improves proxy error message.

Now displays something like this which is helpful for debugging:

6:23:26 PM [vite] http proxy error at /some-path:
Error: getaddrinfo ENOTFOUND somedomain.com
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:84:26)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@fc fc changed the title Include URL of request in proxy errors feat(proxy): Include URL of request in proxy errors Oct 18, 2022
@bluwy bluwy linked an issue Oct 19, 2022 that may be closed by this pull request
7 tasks
@patak-dev patak-dev merged commit 27e2832 into vitejs:main Oct 19, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http proxy errors lacks conte
3 participants